Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: New Picker interactive #691

Merged
merged 381 commits into from
Dec 25, 2023
Merged

refactor: New Picker interactive #691

merged 381 commits into from
Dec 25, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Nov 1, 2023

新交互 (New Design)

image

功能检查 (Functional Check)

RangePicker

Picker

移动端

Holder

Ant Design Side

Copy link

vercel bot commented Nov 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
picker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 25, 2023 7:47am

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (09b3ab1) 98.94% compared to head (38137eb) 98.60%.

Files Patch % Lines
src/PickerInput/SinglePicker.tsx 96.37% 5 Missing ⚠️
src/PickerPanel/DatePanel/index.tsx 93.22% 3 Missing and 1 partial ⚠️
src/PickerInput/Selector/RangeSelector.tsx 94.33% 3 Missing ⚠️
...PickerPanel/TimePanel/TimePanelBody/TimeColumn.tsx 93.87% 2 Missing and 1 partial ⚠️
src/hooks/useTimeConfig.ts 84.21% 3 Missing ⚠️
src/hooks/useTimeInfo.ts 96.29% 3 Missing ⚠️
src/PickerInput/Popup/index.tsx 94.59% 2 Missing ⚠️
src/PickerPanel/MonthPanel/index.tsx 91.30% 2 Missing ⚠️
src/PickerPanel/PanelBody.tsx 96.49% 1 Missing and 1 partial ⚠️
...PickerPanel/TimePanel/TimePanelBody/useScrollTo.ts 95.12% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #691      +/-   ##
==========================================
- Coverage   98.94%   98.60%   -0.34%     
==========================================
  Files          56       63       +7     
  Lines        2458     2364      -94     
  Branches      747      609     -138     
==========================================
- Hits         2432     2331     -101     
- Misses         24       30       +6     
- Partials        2        3       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/examples/debug.tsx Fixed Show fixed Hide fixed
docs/examples/debug.tsx Fixed Show fixed Hide fixed
src/NewPicker/PickerPanel/PanelHeader.tsx Fixed Show fixed Hide fixed
docs/examples/debug.tsx Fixed Show fixed Hide fixed
docs/examples/debug.tsx Fixed Show fixed Hide fixed
src/NewPicker/PickerInput/RangePicker.tsx Fixed Show fixed Hide fixed
src/NewPicker/PickerInput/RangePicker.tsx Fixed Show fixed Hide fixed
src/NewPicker/PickerPanel/DatePanel/index.tsx Fixed Show fixed Hide fixed
This was referenced Feb 20, 2024
@afc163 afc163 mentioned this pull request Jun 11, 2024
@afc163
Copy link
Member

afc163 commented Jun 13, 2024

README 中没有 components

@EliazTray
Copy link

单独面板渲染能力(内联渲染 PickerPanel,不需要 Selector)
这个目前有排在计划内吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants