Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: respect user's preferred color scheme #1375

Conversation

jewhyena
Copy link
Contributor

@jewhyena jewhyena commented Oct 9, 2024

These are the changes to the Docusaurus theme config so that it prefers the user's system color scheme instead of just defaulting to the light one.

I left the light mode as the default for cases when system preferences are unavailable, to be consistent with the official react.dev documentation (see this line of code) and the official React Native documentation (facebook/react-native-website#4262) in this regard.

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for react-navigation-docs ready!

Name Link
🔨 Latest commit f7a9972
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-docs/deploys/6706e1c9ac99ac00085d5393
😎 Deploy Preview https://deploy-preview-1375--react-navigation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@satya164 satya164 merged commit 50dd512 into react-navigation:main Oct 10, 2024
3 checks passed
@jewhyena jewhyena deleted the feat/respect-users-preferred-color-scheme branch October 10, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants