Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the Modal component to block scrolling on any HTML element instead of just the <body> element (#472) #482

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Allow the Modal component to block scrolling on any HTML element instead of just the <body> element (#472) #482

merged 1 commit into from
Sep 13, 2023

Conversation

mbohal
Copy link
Contributor

@mbohal mbohal commented Aug 28, 2023 •
edited by adamkudrna
Loading

Closes #472.

@github-actions github-actions bot added the bug Something isn't working label Aug 28, 2023
@adamkudrna adamkudrna added feature and removed bug Something isn't working labels Sep 11, 2023
@adamkudrna
Copy link
Member

While it's true this PR certainly fixes a specific use case, I'm changing the label to feature because the description of the change (and even the changes in code) sounds more like it's a new thing:

Allow the Modal component to block scrolling on any HTML element instead of just the element

@adamkudrna adamkudrna merged commit fdbf946 into master Sep 13, 2023
11 checks passed
@adamkudrna adamkudrna deleted the bugfix/472 branch September 13, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkudrna adamkudrna adamkudrna approved these changes

@bedrich-schindler bedrich-schindler bedrich-schindler approved these changes

@hubacekj hubacekj hubacekj approved these changes

@dacerondrej dacerondrej dacerondrej approved these changes

Assignees

@mbohal mbohal

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modal component preventScrollUnderneath prop not working
5 participants
@mbohal @adamkudrna @bedrich-schindler @hubacekj @dacerondrej