Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the documentation of CSS usage #528

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Conversation

adamkudrna
Copy link
Member

As a result of #440, component styles are no longer part of the JS bundle. They reside in the extracted react-ui[.development].css file. Therefore:

  1. The Sass scenario is not supported now. Importing just the theme.scss, foundation.scss and helpers.scss makes no sense. Users still have to load the entire CSS bundle which is the only way to get components styles, and it already contains those global style layers.
  2. To allow tree shaking, more steps need to be taken from our side.

Closes #517.

@adamkudrna adamkudrna self-assigned this Mar 6, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 6, 2024
@adamkudrna adamkudrna merged commit 5bdd983 into master Mar 8, 2024
12 checks passed
@adamkudrna adamkudrna deleted the docs/css-usage branch March 8, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS endpoints clarification
3 participants