-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds new transformer for inline code nodes inside table cells #805
feat: adds new transformer for inline code nodes inside table cells #805
Conversation
This unescapes escaped pipe chars loaded into our editor from MD so that users don't have to see them when editing. RM-7646
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, what happens when we write out plain markdown:
md(mdast(``
| td | td |
| - | - |
| `uh \| oh` | |
``))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works when I tested!
This PR was released!🚀 Changes included in v6.66.0 |
🧰 Changes
This unescapes escaped pipe chars when rendering html. There appears to be a bug in remark or rehype where it displays the escaped pipe character in inline code spans within a table cell.
When using pipe characters in code spans within tables, you have to escape the pipe character, otherwise, it would result in additional table cells.
Consider the following markdown:
This would result in:
Which doesn't seem like what was intended.
🧬 QA & Testing