Duplicate key warnings #4
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 11, 2021 14:30
tata9001
reviewed
Jul 13, 2021
| def self.find_duplicate_keys(raw) | ||
| require "psych" | ||
|
|
||
| # Blatantly stolen from https://stackoverflow.com/a/55705853 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want a way to raise errors when there are duplicate keys in the config. This is becoming a bigger problem for us as our yaml files get bigger and bigger, or spread out across hundreds of files. An alternative to this would be to use a yaml / json lint program prior to using them in
ConfigHound.Some challenges here so far are that
SafeYamldoesn't easily support a customobject_classatloadtime, as far as I can tell. I think we'd need to monkey patch something down in thePsychcode, or look into other yaml parsers.The toml parser we're using at the moment already hard fails on duplicate keys, so I feel implementing this feature for that might be quite troublesome, as we are setting the default to allow duplicates for backwards compatibility, and this would raise the question around breaking that for toml, if it was even possible to implement.