Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

feat: Adding Cloudfront response headers policies #1140

Conversation

oliverjfletcher
Copy link
Contributor

Summary

Adding support for Cloudfront response headers policies. This change enables filtering of the managed Cloudfront response headers policies and deletion of custom policies.

Solves #1129

Testing

Filtering of managed Cloudfront response headers policies

global - CloudFrontResponseHeadersPolicy - Managed-SimpleCORS - [ID: "60669652-455b-4ae9-85a4-c4c02393f86c", Name: "Managed-SimpleCORS"] - Cannot delete default CloudFront Response headers policy
global - CloudFrontResponseHeadersPolicy - Managed-CORS-With-Preflight - [ID: "5cc3b908-e619-4b99-88e5-2cf7f45965bd", Name: "Managed-CORS-With-Preflight"] - Cannot delete default CloudFront Response headers policy
global - CloudFrontResponseHeadersPolicy - Managed-CORS-with-preflight-and-SecurityHeadersPolicy - [ID: "eaab4381-ed33-4a86-88ca-d9558dc6cd63", Name: "Managed-CORS-with-preflight-and-SecurityHeadersPolicy"] - Cannot delete default CloudFront Response headers policy
global - CloudFrontResponseHeadersPolicy - Managed-CORS-and-SecurityHeadersPolicy - [ID: "e61eb60c-9c35-4d20-a928-2b84e02af89c", Name: "Managed-CORS-and-SecurityHeadersPolicy"] - Cannot delete default CloudFront Response headers policy
global - CloudFrontResponseHeadersPolicy - Managed-SecurityHeadersPolicy - [ID: "67f7725c-6f97-4210-82d7-5512b31e9d03", Name: "Managed-SecurityHeadersPolicy"] - Cannot delete default CloudFront Response headers policy

Deletion of custom Cloudfront response headers policy

global - CloudFrontResponseHeadersPolicy - awsnuke-test-response-headers-policy - [ID: "f467898e-e286-444b-a23d-e0b36215dbc4", Name: "awsnuke-test-response-headers-policy"] - triggered remove

Removal requested: 1 waiting, 0 failed, 1159 skipped, 0 finished

global - CloudFrontResponseHeadersPolicy - awsnuke-test-response-headers-policy - [ID: "f467898e-e286-444b-a23d-e0b36215dbc4", Name: "awsnuke-test-response-headers-policy"] - waiting

Removal requested: 1 waiting, 0 failed, 1159 skipped, 0 finished

global - CloudFrontResponseHeadersPolicy - awsnuke-test-response-headers-policy - [ID: "f467898e-e286-444b-a23d-e0b36215dbc4", Name: "awsnuke-test-response-headers-policy"] - removed

Removal requested: 0 waiting, 0 failed, 1159 skipped, 1 finished

Nuke complete: 0 failed, 1159 skipped, 1 finished.

@oliverjfletcher oliverjfletcher requested a review from a team as a code owner November 2, 2023 11:06
@oliverjfletcher
Copy link
Contributor Author

@der-eismann can you please review

@der-eismann der-eismann merged commit 9181198 into rebuy-de:main Feb 26, 2024
2 checks passed
@oliverjfletcher oliverjfletcher deleted the feat/cloudfront-response-headers-policies branch February 27, 2024 05:24
bjfish25 added a commit to Optum/aws-nuke that referenced this pull request Jun 21, 2024
* Bump the golang group with 1 update (rebuy-de#1188)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump the golang group with 1 update (rebuy-de#1191)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add release note config (rebuy-de#1192)

* Add support for Redshift Serverless namespaces, snapshots and workgroups. (rebuy-de#1194)

* feat: Adding Cloudfront response headers policies (rebuy-de#1140)

* Bump the golang group with 1 update (rebuy-de#1195)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add ELB Listener Rules object (rebuy-de#1193)

Co-authored-by: Philipp Trulson <[email protected]>

* Bump the golang group with 2 updates (rebuy-de#1201)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump the golang group with 1 update (rebuy-de#1205)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add manual trigger to workflow (rebuy-de#1208)

* Bump the golang group across 1 directory with 2 updates (rebuy-de#1217)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/aws/aws-sdk-go from 1.51.31 to 1.52.3 in the golang group (rebuy-de#1220)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump the golang group across 1 directory with 2 updates (rebuy-de#1227)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/aws/aws-sdk-go from 1.53.10 to 1.53.15 in the golang group (rebuy-de#1229)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add cloudformationiface mock (#19)

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Philipp Trulson <[email protected]>
Co-authored-by: Maarten Dirkse <[email protected]>
Co-authored-by: Oliver Fletcher <[email protected]>
Co-authored-by: Vincent Boulineau <[email protected]>
Co-authored-by: Bradley Fisher <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants