Add url normalization to generator command. #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
generate
command fails if the local stack repo has been set up with ssh urls instead of https urls.Steps to reproduce
reclaim-the-stack
setting its origin to a ssh urle.g.
git remote add origin [email protected]:your-user/your-stack.git
)k
contexthere,
k
will error if we try to insert a ssh url, so we may addhttps://github.com/your-user/your-stack.git
instead, to pass this step).However:
k generate [any args]
A parsing error like:
bad URI(is not URI?): "[email protected]:your-user/your-stack.git" (URI::InvalidURIError)
is raised.PR patches step 3 by comparing a 'normalized' version of the repo path instead.
If this is needed, there may be more places where it can be added - e.g. during setup of the
k
context.👍 / 👎