Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment name and labels #358

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ajaypratap003
Copy link

@ajaypratap003 ajaypratap003 commented Sep 18, 2024

Description

  • Update deployment name rhoai-operator-controller-manager

  • Add new label name: rhoai-operator

  • Fix e2e-tests

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@zdtsw
Copy link

zdtsw commented Sep 18, 2024

i do not see any requirement saying redhat-ods need to be updated => any reason to change this
the only thing i know is rhods should be replaced by rhoai

@ajaypratap003
Copy link
Author

i do not see any requirement saying redhat-ods need to be updated => any reason to change this the only thing i know is rhods should be replaced by rhoai

I don't have strong opinion. @VaishnaviHire suggested that we should also change deployment name in rhods-operator repo as well.
@VaishnaviHire wdyt ?

@zdtsw
Copy link

zdtsw commented Sep 18, 2024

i do not see any requirement saying redhat-ods need to be updated => any reason to change this the only thing i know is rhods should be replaced by rhoai

I don't have strong opinion. @VaishnaviHire suggested that we should also change deployment name in rhods-operator repo as well. @VaishnaviHire wdyt ?

ok, if this is to match nightly i am fine

Copy link

openshift-ci bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ajaypratap003, asanzgom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ajaypratap003,asanzgom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -0,0 +1,24 @@
apiVersion: v1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a question about this file #361 (comment)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VaishnaviHire Can you please confirm that we should keep this file or not in PR ?

@@ -2,15 +2,9 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
creationTimestamp: null
name: prometheus-k8s-viewer
name: rhoai-operator-metrics-reader

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this clusterrole is updated?

Copy link
Author

@ajaypratap003 ajaypratap003 Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't update this manually. It updated by deployment name change after running make bundle cmd. This is new file with prefix rhoai which is generate by controller-gen.

@openshift-ci openshift-ci bot removed the lgtm label Sep 27, 2024
Copy link

openshift-ci bot commented Sep 27, 2024

New changes are detected. LGTM label has been removed.

@ajaypratap003 ajaypratap003 changed the title Update deployment name Update deployment name and labels Oct 3, 2024
@VaishnaviHire
Copy link

This PR should fix unnecessary bundle updates #370

@VaishnaviHire
Copy link

@ajaypratap003 Just an fyi we need to update deployment here https://gitlab.cee.redhat.com/data-hub/rhods-cpaas-midstream/-/merge_requests/2795 to match the one in this repo rhoai-operator-controller-manager

@VaishnaviHire
Copy link

/test rhods-operator-e2e

1 similar comment
@ajaypratap003
Copy link
Author

/test rhods-operator-e2e

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants