-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deployment name and labels #358
base: main
Are you sure you want to change the base?
Update deployment name and labels #358
Conversation
i do not see any requirement saying |
I don't have strong opinion. @VaishnaviHire suggested that we should also change deployment name in |
ok, if this is to match nightly i am fine |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ajaypratap003, asanzgom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -0,0 +1,24 @@ | |||
apiVersion: v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a question about this file #361 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VaishnaviHire Can you please confirm that we should keep this file or not in PR ?
@@ -2,15 +2,9 @@ apiVersion: rbac.authorization.k8s.io/v1 | |||
kind: ClusterRole | |||
metadata: | |||
creationTimestamp: null | |||
name: prometheus-k8s-viewer | |||
name: rhoai-operator-metrics-reader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason this clusterrole is updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't update this manually. It updated by deployment name change after running make bundle
cmd. This is new file with prefix rhoai which is generate by controller-gen.
New changes are detected. LGTM label has been removed. |
This PR should fix unnecessary bundle updates #370 |
@ajaypratap003 Just an fyi we need to update deployment here https://gitlab.cee.redhat.com/data-hub/rhods-cpaas-midstream/-/merge_requests/2795 to match the one in this repo |
/test rhods-operator-e2e |
1 similar comment
/test rhods-operator-e2e |
9b91739
to
5d440fa
Compare
5d440fa
to
cf54ee1
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Update deployment name
rhoai-operator-controller-manager
Add new label name: rhoai-operator
Fix e2e-tests
How Has This Been Tested?
Screenshot or short clip
Merge criteria