Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Sync manifests from cpaas-midstream #374

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VaishnaviHire
Copy link

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@VaishnaviHire
Copy link
Author

I need to check the resource names for Cluster role and cluseterrolebinding

@VaishnaviHire VaishnaviHire changed the title Sync manifests from cpaas-midstream [wip] Sync manifests from cpaas-midstream Oct 10, 2024
@VaishnaviHire VaishnaviHire marked this pull request as draft October 10, 2024 00:11
@zdtsw
Copy link

zdtsw commented Oct 10, 2024

i made a #375 to catch up other parts.

and some questions:

  • will devops automation replace image: REPLACE_IMAGE:latest , instead of the current image: "${ODH_OPERATOR_IMAGE}" ?
  • will "subscription" be done by devops automation?
  • will "olm.skipRange: '>=1.0.0 <2.0.0'" be replaced by automation?

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants