This repository has been archived by the owner on Jan 10, 2021. It is now read-only.
1.0 API #19
Merged
1.0 API #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kellyredding
commented
Mar 15, 2012
kellyredding
commented
- workbook build is run in the context of the Workbook object
- pass in data to the build context using a data hash (outside instance variables no longer applied to the build context)
- uses an element stack to track the current element being build
- has a builder-style render option
- only the latest row object (per worksheet) is cached in memory for self referencing
- improved memory handling and performace (Memory bloating on large data #11)
- pass in data as an arg when initializing a cell objects (pass in data as an arg when initializing a cell object #15)
- pass in name of worksheet as an arg
- better structured to drive many different types of writers - not just Xmlss
* will no longer instance_eval/exec each on each element * all build execution will now run in the scope of the workbook * or, if using a builder style approach, the scope of the caller * this means the workbook will store reference collections and provide an api for adding to and referencing them
* style objects are created, stored, and referenced from the workbook scope * style directives no longer defined in the scope of the style obj * workbook proxies style obj directives
* elements are created to validate and store data * these are then passed to the writer who is responsible for using the data as it sees fit * all element creation is done in the scope of the workbook
* mixins, partials, templates, and styles all build in a consistant manner with the new api changes
Conflicts: Gemfile.lock
* using the builder render approach * using the updated Xmlss API that is Osheet compatible
* adding in to_s, to_data, and to_file workbook meths * removing all view handler stuff (addresses #17) * getting name, colspan, rowspan attribute setting hooked up * updating the examples to run on the new API
kellyredding
added a commit
that referenced
this pull request
Mar 15, 2012
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.