Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-existent param app_config from configure_context docstring #999

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove non-existent param app_config from configure_context docstring #999

wants to merge 1 commit into from

Conversation

RyanBalfanz
Copy link
Member

@RyanBalfanz RyanBalfanz commented Oct 14, 2024 •
edited
Loading

Closes #

💸 TL;DR

The function configure_context does not take a param app_config.

baseplate.py/baseplate/__init__.py

Line 380 in 54c7f5f

def configure_context(self, context_spec: Dict[str, Any]) -> None:

📜 Details

Design Doc

Jira

🧪 Testing Steps / Validation

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

@RyanBalfanz RyanBalfanz marked this pull request as ready for review October 14, 2024 16:04
@RyanBalfanz RyanBalfanz requested a review from a team as a code owner October 14, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskuehl chriskuehl Awaiting requested review from chriskuehl chriskuehl is a code owner automatically assigned from reddit/baseplate-py

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RyanBalfanz