Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.11.x pre-release compatibility #8

Merged
merged 3 commits into from
Sep 27, 2024
Merged

0.11.x pre-release compatibility #8

merged 3 commits into from
Sep 27, 2024

Conversation

Krakabek
Copy link
Collaborator

Description:

This PR makes devvit-kit easier to integrate in projects that use 0.11.x pre-releases
Our old syntax did not work well with the 0.11.x pre-releases due to specifics of how semver treats prereleases

If a version has a prerelease tag (for example, 1.2.3-alpha.3) then it will only be allowed to satisfy comparator sets if at least one comparator with the same [major, minor, patch] tuple also has a prerelease tag.

The >=0.10.20 would match the 0.11.0, but not any of the 0.11.0 prereleases

I decided that setting "*" is fine since public-api is a peer dependency and we don't support versions below 0.10.20 anyway

I also updated the vitest version to match the one we use in public-api

🧪 Testing Steps / Validation

Tested with npm link on a test project outside of monorepo

✅ Checks

  • Contributor License Agreement (CLA) completed if not a Reddit employee

@Krakabek Krakabek merged commit 45a1105 into main Sep 27, 2024
1 check passed
@Krakabek Krakabek deleted the 11-compatibility-main branch September 27, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants