Maintain HOLDOVER for BC/OC when faulty interface returns until Clock is locked

[aneeshkp]

This PR introduces a change to the Boundary Clock (BC) and Ordinary Clock (OC) behavior, ensuring that the system remains in the HOLDOVER state when a previously faulty interface becomes operational again. The holdover state will persist until the PTP synchronization state is detected as LOCKED or until the holdover duration times out.

Key Changes:

Added logic to maintain the HOLDOVER state after a faulty interface recovers, preventing premature exit from holdover.

HOLDOVER will remain active until either:

•      The PTP sync state transitions to LOCKED.
  

•     The holdover timer reaches its limit and times out.
  

  Ensured this behavior applies to both BC and OC configurations.

Purpose:

This change helps to maintain clock stability by ensuring that the system does not exit the holdover state prematurely, potentially leading to timing inaccuracies during the recovery process. The clock will only transition out of holdover once it has re-locked or holdover timeout ( in this case state to freerun ) , ensuring precise time synchronization.
This PR will help when Holdover is correctly implemented for Boundary Clock and Ordinary Clock

[openshift-ci-robot]

@aneeshkp: This pull request references Jira Issue OCPBUGS-41636, which is invalid:

• expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR introduces a change to the Boundary Clock (BC) and Ordinary Clock (OC) behavior, ensuring that the system remains in the HOLDOVER state when a previously faulty interface becomes operational again. The holdover state will persist until the PTP synchronization state is detected as LOCKED or until the holdover duration times out.

Key Changes:

Added logic to maintain the HOLDOVER state after a faulty interface recovers, preventing premature exit from holdover.
HOLDOVER will remain active until either:

•      The PTP sync state transitions to LOCKED.
  

•     The holdover timer reaches its limit and times out.
  

  Ensured this behavior applies to both BC and OC configurations.

Purpose:

This change helps to maintain clock stability by ensuring that the system does not exit the holdover state prematurely, potentially leading to timing inaccuracies during the recovery process. The clock will only transition out of holdover once it has re-locked, ensuring precise time synchronization.
This PR will help when Holdover is correctly implemented for Boundary Clock and Ordinary Clock

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[aneeshkp]

/jira refresh

[openshift-ci-robot]

@aneeshkp: This pull request references Jira Issue OCPBUGS-41636, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[aneeshkp]

/jira refresh

[openshift-ci-robot]

@aneeshkp: This pull request references Jira Issue OCPBUGS-41636, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vitus133]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aneeshkp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vitus133]

/lgtm

[openshift-ci-robot]

@aneeshkp: Jira Issue OCPBUGS-41636: All pull requests linked via external trackers have merged:

• redhat-cne/cloud-event-proxy#352

Jira Issue OCPBUGS-41636 has been moved to the MODIFIED state.

In response to this:

This PR introduces a change to the Boundary Clock (BC) and Ordinary Clock (OC) behavior, ensuring that the system remains in the HOLDOVER state when a previously faulty interface becomes operational again. The holdover state will persist until the PTP synchronization state is detected as LOCKED or until the holdover duration times out.

Key Changes:

Added logic to maintain the HOLDOVER state after a faulty interface recovers, preventing premature exit from holdover.

HOLDOVER will remain active until either:

•      The PTP sync state transitions to LOCKED.
  

•     The holdover timer reaches its limit and times out.
  

  Ensured this behavior applies to both BC and OC configurations.

Purpose:

This change helps to maintain clock stability by ensuring that the system does not exit the holdover state prematurely, potentially leading to timing inaccuracies during the recovery process. The clock will only transition out of holdover once it has re-locked or holdover timeout ( in this case state to freerun ) , ensuring precise time synchronization.
This PR will help when Holdover is correctly implemented for Boundary Clock and Ordinary Clock

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: cloud-event-proxy
This PR has been included in build cloud-event-proxy-container-v4.18.0-202409101811.p0.g263db54.assembly.stream.el9.
All builds following this will include this PR.

[aneeshkp]

/cherry-pick release-4.17

[openshift-cherrypick-robot]

@aneeshkp: new pull request created: #360

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.