-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintain HOLDOVER for BC/OC when faulty interface returns until Clock is locked #352
Conversation
@aneeshkp: This pull request references Jira Issue OCPBUGS-41636, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@aneeshkp: This pull request references Jira Issue OCPBUGS-41636, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@aneeshkp: This pull request references Jira Issue OCPBUGS-41636, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Signed-off-by: Aneesh Puttur <[email protected]>
ef8d90a
to
15fe3a1
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aneeshkp, vitus133 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
263db54
into
redhat-cne:main
@aneeshkp: Jira Issue OCPBUGS-41636: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-41636 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: cloud-event-proxy |
/cherry-pick release-4.17 |
@aneeshkp: new pull request created: #360 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR introduces a change to the Boundary Clock (BC) and Ordinary Clock (OC) behavior, ensuring that the system remains in the HOLDOVER state when a previously faulty interface becomes operational again. The holdover state will persist until the PTP synchronization state is detected as LOCKED or until the holdover duration times out.
Key Changes:
Added logic to maintain the HOLDOVER state after a faulty interface recovers, preventing premature exit from holdover.
Ensured this behavior applies to both BC and OC configurations.
Purpose:
This change helps to maintain clock stability by ensuring that the system does not exit the holdover state prematurely, potentially leading to timing inaccuracies during the recovery process. The clock will only transition out of holdover once it has re-locked or holdover timeout ( in this case state to freerun ) , ensuring precise time synchronization.
This PR will help when Holdover is correctly implemented for Boundary Clock and Ordinary Clock