Skip to content

Commit

Permalink
fix Dockerfile (#14)
Browse files Browse the repository at this point in the history
  • Loading branch information
edcdavid authored Oct 3, 2024
1 parent 9890c1f commit 3d69f92
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM registry.access.redhat.com/ubi9/ubi@sha256:9e6a89ab2a9224712391c77fab2ab01009e387aff42854826427aaf18b98b1ff
RUN dnf -y install iputils iproute ethtool pciutils; dnf clean all
RUN dnf -y remove python3-setuptools
RUN dnf -y --disableplugin=subscription-manager install iputils iproute ethtool pciutils; dnf clean all --disableplugin=subscription-manager

Check failure on line 2 in Dockerfile

View workflow job for this annotation

GitHub Actions / Run Linters, Vet and unit tests

DL3041 warning: Specify version with `dnf install -y <package>-<version>`.
RUN dnf -y --disableplugin=subscription-manager remove python3-setuptools
COPY l2discovery-linux-amd64 /usr/bin
COPY l2discovery-linux-arm64 /usr/bin
RUN \
Expand All @@ -11,6 +11,5 @@ RUN \
else \
echo "CPU architecture is not supported." && exit 1; \
fi
COPY l2discovery /usr/bin
USER 0

Check failure on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / Run Linters, Vet and unit tests

DL3002 warning: Last USER should not be root
CMD ["/bin/sh", "-c", "/usr/bin/l2discovery"]
2 changes: 1 addition & 1 deletion scripts/image.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/sh
set -x
VERSION=multi
VERSION=latest
IMAGE_NAME=l2discovery
REPO=quay.io/redhat-cne
make test
Expand Down

0 comments on commit 3d69f92

Please sign in to comment.