Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Dockerfile #16

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix Dockerfile #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM registry.access.redhat.com/ubi9/ubi@sha256:9e6a89ab2a9224712391c77fab2ab01009e387aff42854826427aaf18b98b1ff
RUN dnf -y --disableplugin=subscription-manager install iputils iproute ethtool pciutils && dnf clean all --disableplugin=subscription-manager
RUN dnf -y --disableplugin=subscription-manager install iputils iproute ethtool pciutils

Check failure on line 2 in Dockerfile

View workflow job for this annotation

GitHub Actions / Run Linters, Vet and unit tests 

DL3040 warning: `dnf clean all` missing after dnf command.

Check failure on line 2 in Dockerfile

View workflow job for this annotation

GitHub Actions / Run Linters, Vet and unit tests 

DL3041 warning: Specify version with `dnf install -y <package>-<version>`.
RUN dnf -y --disableplugin=subscription-manager remove python3-setuptools

Check failure on line 3 in Dockerfile

View workflow job for this annotation

GitHub Actions / Run Linters, Vet and unit tests 

DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
COPY l2discovery-linux-amd64 /usr/bin
COPY l2discovery-linux-arm64 /usr/bin
RUN \
Expand All @@ -11,5 +11,5 @@
else \
echo "CPU architecture is not supported." && exit 1; \
fi
USER 0

Check failure on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / Run Linters, Vet and unit tests 

DL3002 warning: Last USER should not be root
CMD ["/bin/sh", "-c", "/usr/bin/l2discovery"]
Loading