Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Showroom role - add support for sshkeys #7286

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Showroom role - add support for sshkeys #7286

merged 2 commits into from
Nov 1, 2023

Conversation

tonykay
Copy link
Collaborator

@tonykay tonykay commented Oct 31, 2023

SUMMARY

Allows ssh keys instead of user/password to be used by showroom

  • creates keys
  • adds to users authorized_keys
  • Updates tty orchestration
  • More secure
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

roles/showroom

ADDITIONAL INFORMATION

agonzalezrh
agonzalezrh approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@agonzalezrh agonzalezrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tonykay tonykay merged commit 3ffdebe into development Nov 1, 2023
3 checks passed
@tonykay tonykay deleted the showroom-sshkeys-01 branch November 1, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agonzalezrh agonzalezrh agonzalezrh approved these changes

@prakhar1985 prakhar1985 Awaiting requested review from prakhar1985

@miteshget miteshget Awaiting requested review from miteshget

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonykay @agonzalezrh