Fix identifying Mono vs CoreCLR runtimes #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently use `mono-gc.h` as signal that the runtime is a mono-based
runtime. Unfortuatnely, that file is only included with 7.0. This makes
us mis-identify Mono-based 6.0 runtimes as CoreCLR-based instead.
Instead, use libcoreclrtraceptprovider.so which is available
CoreCLR-based platforms (eg, x86_64) but not Mono-based ones. This file
exists on 6.0 and later:
$ find /usr/lib64/dotnet -iname libcoreclrtraceptprovider.so
/usr/lib64/dotnet/shared/Microsoft.NETCore.App/8.0.0-preview.5.23280.8/libcoreclrtraceptprovider.so
/usr/lib64/dotnet/shared/Microsoft.NETCore.App/7.0.7/libcoreclrtraceptprovider.so
/usr/lib64/dotnet/shared/Microsoft.NETCore.App/6.0.18/libcoreclrtraceptprovider.so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use
mono-gc.has signal that the runtime is a mono-based runtime. Unfortuatnely, that file is only included with 7.0. This makes us mis-identify Mono-based 6.0 runtimes as CoreCLR-based instead.Instead, use libcoreclrtraceptprovider.so which is available CoreCLR-based platforms (eg, x86_64) but not Mono-based ones. This file exists on 6.0 and later: