Support setting a test specific timeout through test.json. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables setting a higher timeout than the default for tests that are expected to take longer.
tmds
commented
Sep 5, 2023
Turkey/TestOutputFormat.cs
Outdated
| string elapsedTime = testTime.TotalMilliseconds.ToString(); | ||
| int minutes = (int)testTime.TotalMinutes; | ||
| string elapsedTime = minutes == 0 ? $"{testTime.Seconds}s" | ||
| : $"{minutes}m {testTime.Seconds}s"; |
There was a problem hiding this comment.
I've also included this (unrelated) change which makes it easier to read the elapsed time.
There was a problem hiding this comment.
A bunch of tests now show (0s). Do you think printing the time in milliseconds might be useful for those tests?
There was a problem hiding this comment.
I can add additional code to round that up to 1s, but the millisecond precision isn't useful imo.
omajid
reviewed
Sep 5, 2023
omajid
reviewed
Sep 7, 2023
Co-authored-by: Omair Majid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65.
This enables setting a higher timeout than the default for tests that are expected to take longer.