Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Initial commit #1

wants to merge 2 commits into from

Conversation

vitus133
Copy link

@vitus133 vitus133 commented Apr 3, 2022

/cc @serngawy @imiller0
I started to put up some stories and use cases for ACM enhancement proposal.
Opening this for comments about the format, content, ...
Cheers!

Copy link

@serngawy serngawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As general idea of having a cascade deleting of the policy object-templates from the spoke clusters is really nice and needed the use-cases in the proposal are good examples for that. However, the conflict cases with policy remediationAction and complianceType need to be clarified. For example; when the policy remediationAction set to inform the deleteOption should not get applied. Another example; when the policy complianceType set to MustNotHave the deleteOption for partially orphaned will make conflict.
I believe the enhancement proposal need to list those cases and what decision will be made for each case.

# - "orphan": remove any ACM annotations added by the policy and leave the object intact
# - "delete": delete the object
# - "revert": reverts the object to the pre-managed state (in case it existed before the policy was applied)
deleteOption: "delete"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be better to have the deleteOption also under spec so it get applied for all object-templates. Similar to the remediationAction in Policy & ConfigurationPolicy

@imiller0
Copy link

imiller0 commented Sep 1, 2022

Is this at least partially implemented by: open-cluster-management-io#67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants