Extend rdbloader to support FD #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
moticless
commented
Aug 13, 2023
•
moticless
commented
- Fixing rdb parsing of empty database
- To be on the safe side, handling of Incomplete writev()
- Extend RespToTcpLoader to support FD
- Rebrand RespToTcpLoader to be RespToRedisLoader.
- Extend RdbxToResp to support flag delKeyBeforeWrite.
- Extend RdbxRespToRedisLoader to know mapping RX RESP error to TX CMD.
oranagra
reviewed
Aug 15, 2023
oranagra
previously approved these changes
Aug 17, 2023
moticless
force-pushed
the
extend-rdbloader-api2
branch
from
31b7c1c
to
2da4cd9
Compare
oranagra
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.