Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

c99 ; remove dstRdbVersion ; support expire, del before write, Functions #14

Merged
merged 10 commits into from
Sep 5, 2023
Merged

c99 ; remove dstRdbVersion ; support expire, del before write, Functions #14

merged 10 commits into from
Sep 5, 2023

Conversation

moticless
Copy link
Collaborator

@moticless moticless commented Aug 28, 2023 •
edited
Loading

Commits:

  • Use standard c99 instead of gnu99
  • Remove dstRdbVersion from RdbxToRespConf API
  • RDB2RESP: Support EXPIRE and DEL-KEY-BEFORE-WRITE
  • Support LRU & LFU
  • Extend parser to support Functions.
  • Rename respFileWriter to respToFileWriter (to align with respToRedisLoader)
  • RDB2RESP: Remove SELECT command exclusion flag from API

oranagra
oranagra reviewed Aug 29, 2023
View reviewed changes
api/librdb-ext-api.h Outdated Show resolved Hide resolved
src/ext/handlersToResp.c Show resolved Hide resolved
api/librdb-ext-api.h Outdated Show resolved Hide resolved
src/ext/respToRedisLoader.c Outdated Show resolved Hide resolved
src/lib/parser.c Show resolved Hide resolved
@moticless moticless changed the title c99 ; remove dstRdbVersion ; support expire and del before write c99 ; remove dstRdbVersion ; support expire, del before write, Functions Aug 31, 2023
oranagra
oranagra previously approved these changes Aug 31, 2023
View reviewed changes
@moticless moticless merged commit b67497e into redis:main Sep 5, 2023
1 check passed
@moticless moticless deleted the various-changes branch September 5, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tezc tezc tezc left review comments

@YaacovHazan YaacovHazan YaacovHazan left review comments

@oranagra oranagra oranagra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moticless @oranagra @tezc @YaacovHazan