fix: remove id field from ctx.loader

BREAKING CHANGE: we no longer allow `id` so it'll TS will be unhappy
redux-saga · Aug 2, 2023 · 10451a4 · 10451a4
1 parent 6f4230b
commit 10451a4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/middleware.test.ts b/src/middleware.test.ts
@@ -292,7 +292,6 @@ test('overriding default loader behavior', (t) => {
   const fetchUsers = api.create(
     `/users`,
     function* (ctx: ApiCtx<any, { users: User[] }>, next) {
-      const id = ctx.name;
       yield next();
 
       if (!ctx.json.ok) {
@@ -304,7 +303,7 @@ test('overriding default loader behavior', (t) => {
         return acc;
       }, {});
 
-      ctx.loader = { id, message: 'yes', meta: { wow: true } };
+      ctx.loader = { message: 'yes', meta: { wow: true } };
       ctx.actions.push(users.actions.add(curUsers));
     },
   );

diff --git a/src/types.ts b/src/types.ts
@@ -66,7 +66,7 @@ export interface FetchJsonCtx<P = any, ApiSuccess = any, ApiError = any>
 export interface ApiCtx<Payload = any, ApiSuccess = any, ApiError = any>
   extends FetchJsonCtx<Payload, ApiSuccess, ApiError> {
   actions: Action[];
-  loader: LoadingMapPayload<Record<string, any>> | null;
+  loader: Omit<LoadingMapPayload<Record<string, any>>, 'id'> | null;
   cache: boolean;
   cacheData: any;
 }