Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close bullet list after hitting enter on empty list line #328

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Calamari
Copy link

@Calamari Calamari commented Feb 2, 2020

Since I like this convenience on every markdown editor I go, I thought I add this here too. This adds the following behavior:

Hitting enter on empty list rows, will close the (numbered) bullet list.

Here an example:

When having the following content in a textarea (| is representing the caret):

- list 1
- |

something more...

After hitting enter the content will now look like this:

- list 1

|

something more...

instead of this:

- list 1
- 
- |

something more...

I added the same for numbered bullet lists.

As a bonus, I also fixed the bug, that hitting enter on a line like 9. will misplace the caret about one character, since the length of the old number was used, instead of the added 10..

Note about testing:

Since there are no tests in this repository, I tested all the cases I could come up with manually.

If something is missing, or you want to have something changed. I am eager to do it. I would like to have this feature in. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant