Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change inputInFocusedRegion such that it filters mouse scroll wheel input based on focus #73

Conversation

minimapletinytools
Copy link
Member

@minimapletinytools minimapletinytools commented Jul 6, 2023

Note even if we decide to merge #72 this PR should be merged as this seems like better behavior for inputInFocusedRegion anyways.

@ali-abrar ali-abrar merged commit 9b7311e into reflex-frp:develop Jul 7, 2023
12 checks passed
@ali-abrar
Copy link
Member

I think this also needs e365940, which is what you had in 4eee394 - any reason that didn't work out?

@minimapletinytools
Copy link
Member Author

minimapletinytools commented Jul 7, 2023

I think this also needs e365940, which is what you had in 4eee394 - any reason that didn't work out?

It wasn't working for the file menu in tinytools-vty. I have the scroll bbar in a child pane to the pane that I want the scrolling action to happen in

       ╔═══════════════════════════════════╗                                                                                          
       ║pane that I want to scroll      ╔═╗║                                                                                          
       ║                                ║s║║                                                                                          
       ║                                ║c║║                                                                                          
       ║                                ║r║║                                                                                          
       ║                                ║o║║                                                                                          
       ║                                ║l║║                                                                                          
       ║                                ║l║║                                                                                          
       ║                                ║ ║║                                                                                          
       ║                                ║b║║                                                                                          
       ║                                ║a║║                                                                                          
       ║                                ║r║║                                                                                          
       ║                                ╚═╝║                                                                                          
       ╚═══════════════════════════════════╝     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants