upgrade to vty >=6 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure where bimap should go in default.nix and I may have gotten the other callHackageDirect stuff wrong. |
ali-abrar
approved these changes
Jan 21, 2024
|
I'll have a look at the failing check and then this can be merged. Thanks! |
414owen
reviewed
Jan 21, 2024
|
Released to hackage as 0.5.2.0, along with #78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades reflex-vty to use vty >=6 which has a few breaking changes in order to support cross platform.
Testing: ran examples fine on mac. Still need to try and linux and windows.