Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Uncaught in promise errors in console when no catch is provided #12

Merged

Conversation

benglass
Copy link
Contributor

Issue: #4

This approach feels a bit hacky perhaps but it employs the suggestions from

reflux/refluxjs#403

That users call these asyncResult actions using

action().catch(function(){});

It just does this in the library automatically so that if the user does not provide a catch (and they shouldnt have to) it is not a browser/console error.

RobinClowers added a commit to substantial/refluxjs that referenced this pull request Nov 19, 2015
@benglass
Copy link
Contributor Author

@spoike ping!

@benglass
Copy link
Contributor Author

benglass commented Dec 8, 2015

@spoike ping! I read the thread and congratulations on the addition to your family.

We are using your great library on a couple of projects and would love to contribute to continued development.

@benglass
Copy link
Contributor Author

@spoike @tmbtech ping! There are a few people forking off of this PR now to resolve this issue with uncaught promise errors. If this is not the preferred fix then can you give me some guidance on what the right way to resolve the issue would be? If not then can we get this merged in?

spoike added a commit that referenced this pull request Jan 20, 2016
…e_error

Fix Uncaught in promise errors in console when no catch is provided
@spoike spoike merged commit 1dbc999 into reflux:master Jan 20, 2016
@spoike
Copy link
Member

spoike commented Jan 20, 2016

Sorry, I'll try to update the npm package ASAP now.

@benglass
Copy link
Contributor Author

@spoike Thanks a lot! Let me know if you are looking for maintainers on Reflux. I think its a neat flux implementation that is a good bit easier to wrap your head around than some of the other options and since we are using it on a few projects id love to see it continue to be maintained.

@spoike
Copy link
Member

spoike commented Jan 20, 2016

Yes I am looking for maintainers. Check #15
ons 20 jan. 2016 kl. 16:52 skrev Ben Glassman [email protected]:

@spoike https://github.com/spoike Thanks a lot! Let me know if you are
looking for maintainers on Reflux. I think its a neat flux implementation
that is a good bit easier to wrap your head around than some of the other
options and since we are using it on a few projects id love to see it
continue to be maintained.


Reply to this email directly or view it on GitHub
#12 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants