Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rocksdb and non-state-breaking version bumps #677

Merged
merged 8 commits into from
Feb 7, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jan 2, 2022

Description

In most cosmos chains, rocksdb doesn't work but it is the cheapest possible performance boost, and this matters for embedded devices.

For a sync from genesis, you'll find that this is also a dramatic performance boost.

For relaying, this will help avoid account sequence errors.

PS: We ("the community") need a way to quantify this stuff beyond "it's faster, trust me" but here's my best try:

tendermint/tm-db#211

I'll try more and it'll get better.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@faddat faddat changed the title rocksdb and non-state-breaking version bumps chore: rocksdb and non-state-breaking version bumps Jan 2, 2022
@amaury1093 amaury1093 self-assigned this Jan 3, 2022
@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #677 (b3f27e5) into master (63eb64d) will decrease coverage by 7.87%.
The diff coverage is n/a.

❗ Current head b3f27e5 differs from pull request most recent head e319355. Consider uploading reports for the commit e319355 to get more accurate results

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
- Coverage   74.74%   66.86%   -7.88%     
==========================================
  Files         118      105      -13     
  Lines       19542    14692    -4850     
==========================================
- Hits        14606     9824    -4782     
- Misses       3963     4106     +143     
+ Partials      973      762     -211     
Flag Coverage Δ
experimental-codecov ?
stable-codecov 66.86% <ø> (-0.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@faddat
Copy link
Contributor Author

faddat commented Jan 3, 2022

NB: I am not sure why this seems to have affected test coverage (and lots)

It doesn't change any of the code in regen-ledger

Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution. Could you resolve conflicts?

go.mod Outdated
)

replace google.golang.org/grpc => google.golang.org/grpc v1.33.2

replace github.com/tecbot/gorocksdb => github.com/cosmos/gorocksdb v1.1.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this permanent? Or is there a plan to upstream the cosmos changes to tecbot, and use tecbot in the future?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have custom changes in gorocksdb for store/v2

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have v1.2.0, so let's use v1.2.0

@ryanchristo
Copy link
Member

@faddat can you resolve the conflicts or would you prefer one of us to do so?

@robert-zaremba
Copy link
Collaborator

let's update cosmos/gorocksdb to v1.2.0

@amaury1093
Copy link
Contributor

gentle ping @faddat

@robert-zaremba robert-zaremba enabled auto-merge (squash) January 27, 2022 16:43
@robert-zaremba
Copy link
Collaborator

@faddat could you resolve the conflicts? Thanks.

auto-merge was automatically disabled January 29, 2022 09:34

Head branch was pushed to by a user without write access

@robert-zaremba robert-zaremba enabled auto-merge (squash) February 7, 2022 15:03
@robert-zaremba robert-zaremba merged commit ad61b50 into regen-network:master Feb 7, 2022
@ryanchristo ryanchristo mentioned this pull request Mar 14, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants