Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding celery as a doc requirement. #39

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

fuzzball81
Copy link
Member

Celery needs to be added to the docs requirements so that the documentation for CeleryScaffold is properly generated.

Also fixed up missing '-' in the main rst file.

jpichon
jpichon previously approved these changes Apr 9, 2024
docs/flask_container_scaffold.rst Show resolved Hide resolved
@jguiditta
Copy link
Member

I think this should solve the issue on readthedocs. However, for building this in a local checkout, I had to also add celery to the dev-packages list in the Pipfile.

Celery needs to be added to the docs requirements so that the
documentation for CeleryScaffold is properly generated.

Also fixed up missing '-' in the main rst file.

Signed-off-by: Jason Joyce <[email protected]>
@fuzzball81
Copy link
Member Author

I think this should solve the issue on readthedocs. However, for building this in a local checkout, I had to also add celery to the dev-packages list in the Pipfile.

Totally forgot about the Pipfile, thanks for the reminder! The latest version should include celery in the dev-packages list.

@jguiditta jguiditta enabled auto-merge (rebase) April 9, 2024 21:45
Copy link
Member

@jguiditta jguiditta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jguiditta jguiditta merged commit c0b69ef into release-depot:main Apr 10, 2024
7 checks passed
@fuzzball81 fuzzball81 deleted the celery-doc-genfix branch April 10, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants