Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes, use upload by date-time and added a limit to auto-tagger. #60

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ItsKaa
Copy link

@ItsKaa ItsKaa commented Nov 9, 2024

Couple of improvements and some fixes for crashes that I found.

  • Handling various exceptions:
    • pixiv_tags was defined inside a try-except but was also used outside of it causing in a consistent crash of a url I cannot remember.
    • unhandled extensions: handled the general error under not post_id because the return value was incorrect and also excluded some extra extensions.
    • JSONDecodeError, I believe the name couldn't be found or some other element, best to not crash because of it.
  • Fixed tag sanitization not always being consistent.
  • Added a limit to the auto-tagger, there's an underlying problem where it seems to take up too many file handles, I haven't really find the cause and it only happens when dealing with a lot of files, a limit of 1000 works fine for me. Also might help some people out dealing with API limits.
  • Uploading files based on the file date, either from the metadata or the modified date (for accurate dates, it will require setting this up in the gallery-dl config file). I enjoy having things uploaded in order, especially when doing a bulk import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant