ci with custom git version #330
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,16 +3,39 @@ name: Test | |
| jobs: | ||
| test: | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest] | ||
| git-version: [latest, 2.37.0] | ||
| include: | ||
| - os: ubuntu-latest | ||
| git-version: 2.20.0 | ||
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Install old git version (macOS) | ||
| if: ${{ matrix.os == 'macos-latest' && matrix.git-version != 'latest'}} | ||
| run: | | ||
| brew tap-new mob/local-git | ||
| brew extract --version=${{ matrix.git-version }} git mob/local-git | ||
| brew install git@${{ matrix.git-version }} || brew link --overwrite git@${{ matrix.git-version }} | ||
| - name: Install old git version (ubuntu) | ||
| if: ${{ matrix.os == 'ubuntu-latest' && matrix.git-version != 'latest'}} | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install gettext asciidoc docbook2x | ||
| curl https://mirrors.edge.kernel.org/pub/software/scm/git/git-${{ matrix.git-version }}.tar.gz --output git-${{ matrix.git-version }}.tar.gz | ||
| tar -zxf git-${{ matrix.git-version }}.tar.gz | ||
| cd git-${{ matrix.git-version }} | ||
| make configure | ||
| ./configure --prefix=/usr | ||
| make all info | ||
| sudo make install install-info | ||
| - name: Show git version | ||
| run: git version | ||
| - name: Use Go 1.16.x | ||
| uses: actions/setup-go@v2 | ||
| with: | ||
| go-version: '~1.16.0' | ||
| - name: Test | ||
| run: go test -test.v | ||
|
There was a problem hiding this comment. @gregorriegler do we need that -test.v flag? Or was that just for testing which version works and which not? There was a problem hiding this comment. I added it so I can see the logs, because I didn't have any Feedback. And I think we should now keep it. The tests are not very useful if they don't tell you why they fail. There was a problem hiding this comment. But I agree, we should not need to use this flag in order to get the Feedback we need. I will create an Issue. |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gregorriegler I would remove that. We should fail fast in my opinion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you want it? Are we not failing fast?
Let me tell you why I turned it off. So it was turned on, and what happened was that when one build failed, I didn't get to see the other builds finish. It all suddenly aborted. So I didn't get the feedback where the other builds would have failed and why.
It looks like a good way to save hardware resources. On the other hand I don't understand in what way we're not failing fast, if we keep running the other builds after one of them failed. We did see it fail, so we fail as soon as possible, even with the flag set to false, no?.
On python approvals for example, we also use this flag: https://github.com/approvals/ApprovalTests.Python/blob/ee6312d8848e7ee13e8bb5bafbe96bcd7053aa7a/.github/workflows/test.yml#L10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some research again and github actions seem to be free for all public projects without any limit so this is fine for me.