#410: added duration to latest commit for a remote branch to mob status #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yes and: see my commit |
hollesse
commented
Mar 23, 2024
|
|
||
| func TestStatusDetectsWipBranches(t *testing.T) { | ||
| output, configuration := setup(t) | ||
| start(configuration) |
There was a problem hiding this comment.
I would like to adjust the test that it does not depend on the empty commit when doing mob start. As I would like to remove this empty commit again.
status_test.go
Outdated
| git("checkout", "master") | ||
| time.Sleep(2 * time.Second) |
There was a problem hiding this comment.
ouch, do we really need that?
There was a problem hiding this comment.
I think so. On my machine i ran into the problem that it was exactly one second ago and the test failed. One other option would be to just assert ago or second what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #410
the result of the change can be seen here.
if there is no remote wip branch: