Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the context controls for chat window #345

Open
Tracked by #344
samlhuillier opened this issue Aug 12, 2024 · 14 comments
Open
Tracked by #344

Improve the context controls for chat window #345

samlhuillier opened this issue Aug 12, 2024 · 14 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@samlhuillier
Copy link
Collaborator

Problem

Currently to customise context retrieval settings in each chat, the user has to go into a messy modal to customise each chat which does not make it easy to chat.

Video shows current experience:

357209633-a2bfd9ea-9bbe-43ee-b3d9-324b3be31751.mov

Solution

All the controls in the modal should be moved to a titlebar section immediately visible when a user opens a new chat:

  • The titlebar should allow the user to see the current setting for each of number of context items, date filters and files that have been added to context.
  • And clicking on each of these should open a mini popup/tooltip to customise the setting.

The titlebar should either be at the top of the chat window or at the bottom just above the chat input field. It should also disappear as soon as the first chat message is submitted.

See src/components/Chat/Chat.tsx to get started. Feel free to comment below with questions or other ideas 😀

@samlhuillier samlhuillier added the good first issue Good for newcomers label Aug 12, 2024
@Manas-Kenge
Copy link

Hey There! I am trying to setup the repo locally to solve this issue but I am running into LanceDB Error on Windows. Even after referring the docs the error still persists. I was wondering if you could help.

@sarthakladhwe
Copy link

Hi @samlhuillier, I see that there's some interest in this issue, but it's not currently assigned to anyone. I've started looking into this issue and currently planning on how to resolve it. I’d love to help out with it. Is it okay if I work on this? Thanks!

@weilirs
Copy link
Collaborator

weilirs commented Aug 15, 2024

Hi @samlhuillier, I see that there's some interest in this issue, but it's not currently assigned to anyone. I've started looking into this issue and currently planning on how to resolve it. I’d love to help out with it. Is it okay if I work on this? Thanks!

Anyone can work on this issue, you don't need to be assigned to work on it.

@weilirs
Copy link
Collaborator

weilirs commented Aug 15, 2024

Hey There! I am trying to setup the repo locally to solve this issue but I am running into LanceDB Error on Windows. Even after referring the docs the error still persists. I was wondering if you could help.

You can open an issue and post more details.

@samlhuillier
Copy link
Collaborator Author

It's best if we don't duplicate work! And there's plenty of other cool things to work on!

@Manas-Kenge & @sarthakladhwe could you each confirm if you want to/have started working on this issue?

Also @Manas-Kenge what error message are you seeing with lance db?

@joseplayero
Copy link
Collaborator

/bounty $60

@sarthakladhwe
Copy link

Hi @samlhuillier, I'm working on it. I shall create a pull request soon.

My approach is to position the context settings just above the chat input field. I believe this placement offers better accessibility and visibility for users. Additionally, instead of using popups or tooltips for changing the settings, I suggest integrating the settings directly into the titlebar for a more streamlined and intuitive user experience. I will provide screenshots to illustrate this idea soon. However, if it is preferred to have a popup/tooltip, I am happy to implement that as well.

@sarthakladhwe
Copy link

sarthakladhwe commented Aug 17, 2024

/attempt #345

@joseplayero
Copy link
Collaborator

@sarthakladhwe this approach sounds reasonable to me. as long as all the same settings in the modal can be edited in a nice intuitive ui + a couple of extra settings like llm (and more in the future) then please get started on a PR :)

@sarthakladhwe
Copy link

Hi @samlhuillier @joseplayero, I have linked a draft pull request for this issue. I would love some thoughts on the current approach. Any changes are welcome! :)

@onyedikachi-david
Copy link

onyedikachi-david commented Aug 28, 2024

/attempt #345

Algora profile Completed bounties Tech Active attempts Options
@onyedikachi-david 5 bounties from 2 projects
JavaScript, Shell
Cancel attempt

Just queuing up 🙂

@joseplayero
Copy link
Collaborator

feel free to attack the issue @onyedikachi-david i've re-assigned you to the task!

@aybanda
Copy link

aybanda commented Sep 6, 2024

@joseplayero
/attempt #345

Algora profile Completed bounties Tech Active attempts Options
@aybanda 1 bounty from 1 project
Cancel attempt

@joseplayero
Copy link
Collaborator

i will be taking on this task. apologies to all those who wanted to contribute, this requires some thought and extra refactoring. there will be more issues with bounties very soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
7 participants