Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat): add context settings titlebar for easier customization #388

Conversation

onyedikachi-david
Copy link

Closes #345
/claim #345

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request implements a new context settings titlebar for easier customization of chat context retrieval settings, addressing issue #345. Key changes include:

  • Removed AddContextFiltersModal.tsx and introduced new components ContextSettingsBar.tsx and ContextSettingsPopup.tsx for improved context controls
  • Updated ChatMessages.tsx to include the new ContextSettingsBar component and dynamic titlebar visibility
  • Modified ChatWrapper.tsx to remove AddContextFiltersModal related functionality
  • Updated types.ts to reflect changes in ChatFilters interface, replacing 'numberOfChunksToFetch' with 'numItems'
  • Refactored SearchBarWithFilesSuggestion.tsx for better integration with the new context settings feature

8 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings

src/components/Chat/ContextSettingsBar.tsx Outdated Show resolved Hide resolved
src/components/Chat/ContextSettingsPopup.tsx Outdated Show resolved Hide resolved
src/components/Chat/ContextSettingsPopup.tsx Outdated Show resolved Hide resolved
src/components/Chat/ContextSettingsPopup.tsx Show resolved Hide resolved
src/components/Common/SearchBarWithFilesSuggestion.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@joseplayero joseplayero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for opening this @onyedikachi-david

there are a number of issues with your implementation:

  1. the "add files to context" modal renders all files as a suggestion in a vault which slows the app down massively. you shld instead use the original component that was used for file suggestions in the original modal
  2. please add an offclick so that when the user clicks off outside of any of the modals, the modals dissapear
  3. the design of the buttons, sliders, background colors and date picker are not consistent with the design of the app. please fix that

please make the above changes so that we can merge your code in

Signed-off-by: David Anyatonwu <[email protected]>
Signed-off-by: David Anyatonwu <[email protected]>
@onyedikachi-david
Copy link
Author

reor-2024-08-31_22.57.48.webm

@onyedikachi-david
Copy link
Author

Please review @joseplayero

@joseplayero
Copy link
Collaborator

there are still issues with the quality of this UI you have made and its coherence with the current reor design. then there is a big refactor going on this week with chat so ill put this PR on hold while we wait for that to go ahead because the refactor involves chat. afterwards we can reconsider this PR and the changes needed for this to mergeable

@onyedikachi-david
Copy link
Author

there are still issues with the quality of this UI you have made and its coherence with the current reor design. then there is a big refactor going on this week with chat so ill put this PR on hold while we wait for that to go ahead because the refactor involves chat. afterwards we can reconsider this PR and the changes needed for this to mergeable

Alright. Please let me know when the refactor is done.

@joseplayero
Copy link
Collaborator

apologies David. i will be taking on this task as it requires a large refactor and extra features. there will be many new bounties on the project this coming week

@joseplayero joseplayero closed this Sep 7, 2024
@onyedikachi-david
Copy link
Author

Alright, will I be receiving a tip at least? @joseplayero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the context controls for chat window
2 participants