Add flags to improve RouterServer MapDB perf #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r image" This reverts commit 7a038bc.
bryanwilliams1025
force-pushed
the
bwilliams/map-db-perf
branch
from
f3c2101
to
dd3aac9
Compare
Base automatically changed from
bwilliams/add-map-db-metrics
to
core_update_gh_5
January 3, 2023 22:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some flags to potentially improve the performance when interacting with the MapDB maps. @michaz mentioned core GraphHopper uses these flags in its usage of MapDB, but I also read over the perf docs to see what else is available. Looks like these flags are best for readonly DB operations on 64 bit systems (pretty sure we're fine to assume 64 bit - some of the packages we install already assume it).
This PR sits on top of #132 - I was thinking we could first do a run with the timing info, then try a run with these new flags if the timing info reveals a significant problem.
Core GraphHopper also does some file I/O during PT requests, also involving MapDB with these settings. Depending on how far this change gets us, we might want to measure/improve the Core GraphHopper I/O too. But we can start by introducing better perf flags in our own code, similar to what core GH is already using.