Fix special case in switch expr completion #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
approved these changes
Jun 4, 2024
| @@ -587,6 +587,14 @@ let completionWithParser1 ~currentFile ~debug ~offset ~path ~posCursor | |||
| if Debug.verbose () && debugTypedCompletionExpr then | |||
| print_endline "[typedCompletionExpr] No cases, rest"; | |||
| () | |||
| | Pexp_match (expr, [{pc_lhs; pc_rhs}]) | |||
There was a problem hiding this comment.
Perhaps add a comment here as the case is similar to what's in the comment for the next case.
|
Note to self: This logic can probably be cleaned up a little bit in the future. |
jfrolich
pushed a commit
to jfrolich/rescript-vscode
that referenced
this pull request
Sep 3, 2024
* fixes a special case in switch expr completion * changelog * add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a special case.