Validate init parameters

src/index.ts

@@ -1,6 +1,6 @@
 #!/usr/bin/env node
 
 import { createCommand } from 'commander'
 import execa from 'execa'
 import chalk from 'chalk'
 import fs from 'fs'
@@ -8,44 +8,12 @@
 import { App } from 'rete-kit'
 import { appsCachePath, projects } from './consts'
 import { log } from './ui'
+import { fixtures, getFeatures, stackNames, validate } from './init'
 
 const program = createCommand()
 
 program.version(require('../package.json').version)
 
-const targets: { stack: App.AppStack, versions: number[] }[] = [
-  { stack: 'react', versions: [16, 17, 18] },
-  { stack: 'vue', versions: [2, 3] },
-  { stack: 'angular', versions: [12, 13, 14, 15, 16, 17] },
-  { stack: 'svelte', versions: [3, 4] }
-]
-const stackNames = targets.map(t => t.stack)
-
-const fixtures = targets
-  .map(({ stack, versions }) => versions.map(version => ({ stack, version, folder: `${stack}${version}` as const })))
-  .flat()
-  .map(({ stack, version, folder }) => ({
-    stack,
-    version,
-    folder
-  }))
-
-function getFeatures({ stack, version }: (typeof fixtures)[0], next: boolean) {
-  return [
-    stack === 'angular' && new App.Features.Angular(version as 12 | 13 | 14 | 15, next),
-    stack === 'react' && new App.Features.React(version, stack, next),
-    stack === 'vue' && new App.Features.Vue(version as 2 | 3, next),
-    stack === 'svelte' && new App.Features.Svelte(version as 3 | 4, next),
-    new App.Features.ZoomAt(),
-    new App.Features.OrderNodes(),
-    new App.Features.Dataflow(next),
-    new App.Features.Selectable(),
-    new App.Features.Minimap(next),
-    new App.Features.Reroute(next)
-  ]
-}
-
-
 program
   .command('init')
   .description(`Initialize testing tool`)
@@ -53,22 +21,29 @@
   .option('-n --next')
   .option('-s --stack <stack>', `Stacks to test, comma-separated (${stackNames.join(',')})`)
   .option('-sv --stack-versions <stack-version>', `Versions to test, comma-separated`)
   .action(async (options: { depsAlias: string, stack?: string, stackVersions?: string, next?: boolean }) => {
     if (!process.version.startsWith('v16')) console.info(chalk.yellow('---\nWe recommend using Node.js 16 to avoid any potential issues\n---'))
 
     const next = options.next || false
     const cwd = process.cwd()
     const depsAlias = options.depsAlias ? resolve(cwd, options.depsAlias) : undefined
-    const stacks = options.stack ? options.stack.split(',') : null
+    const stacks = options.stack ? options.stack.split(',') : stackNames
     const stackVersions = options.stackVersions ? options.stackVersions.split(',') : null
 
+    const { error } = validate(stacks, stackVersions)
+
+    if (error) {
+      log('fail', 'FAIL')(chalk.red(error))
+      process.exit(1)
+    }
+
     await fs.promises.mkdir(join(cwd, appsCachePath), { recursive: true })
 
     for (const fixture of fixtures) {
       const features = getFeatures(fixture, next)
       const { folder, stack, version } = fixture
 
-      if (stacks && !stacks.includes(stack)) continue
+      if (!stacks.includes(stack)) continue
       if (stackVersions && !stackVersions.includes(String(version))) continue
 
       log('success')('Start creating', chalk.yellow(stack, `v${version}`), 'application in ', folder)
@@ -94,7 +69,7 @@
   .option('-s --stack <stack>', `Stacks to test, comma-separated (${stackNames.join(',')})`)
   .option('-sv --stack-versions <stack-version>', `Versions to test, comma-separated`)
   .option('-p --project <project>', `Project (${projects.map(p => p.name)})`)
   .action(async (options: { updateSnapshots?: boolean, stack?: string, stackVersions?: string, project?: string, grep?: string }) => {
     const stacks = options.stack ? options.stack.split(',') : null
     const stackVersions = options.stackVersions ? options.stackVersions.split(',') : null
 

src/init/index.ts

@@ -0,0 +1,55 @@
+import { App } from 'rete-kit'
+
+export const targets: { stack: App.AppStack, versions: number[] }[] = [
+  { stack: 'react', versions: [16, 17, 18] },
+  { stack: 'vue', versions: [2, 3] },
+  { stack: 'angular', versions: [12, 13, 14, 15, 16, 17] },
+  { stack: 'svelte', versions: [3, 4] }
+]
+export const stackNames = targets.map(t => t.stack)
+
+export const fixtures = targets
+  .map(({ stack, versions }) => versions.map(version => ({ stack, version, folder: `${stack}${version}` as const })))
+  .flat()
+  .map(({ stack, version, folder }) => ({
+    stack,
+    version,
+    folder
+  }))
+
+export function getFeatures({ stack, version }: (typeof fixtures)[0], next: boolean) {
+  return [
+    stack === 'angular' && new App.Features.Angular(version as 12 | 13 | 14 | 15, next),
+    stack === 'react' && new App.Features.React(version, stack, next),
+    stack === 'vue' && new App.Features.Vue(version as 2 | 3, next),
+    stack === 'svelte' && new App.Features.Svelte(version as 3 | 4, next),
+    new App.Features.ZoomAt(),
+    new App.Features.OrderNodes(),
+    new App.Features.Dataflow(next),
+    new App.Features.Selectable(),
+    new App.Features.Minimap(next),
+    new App.Features.Reroute(next)
+  ]
+}
+
+export function validate(stacks: string[], stackVersions: string[] | null): { error: string | null } {
+  const unknownStacks = stacks.filter(name => !stackNames.includes(name as App.AppStack))
+
+  if (unknownStacks.length > 0) {
+    return { error: `Unknown stack names: ${unknownStacks.join(', ')}` }
+  }
+
+  if (stacks.length > 1 && stackVersions && stackVersions.length > 0) {
+    return { error: `You can't specify versions for multiple stacks` }
+  }
+
+  if (stacks.length === 1 && stackVersions && stackVersions.length > 0) {
+    const unknownVersions = stackVersions.filter(v => !targets.find(t => t.stack === stacks[0])?.versions.includes(Number(v)))
+
+    if (unknownVersions.length > 0) {
+      return { error: `Unknown stack versions: ${unknownVersions.join(', ')}` }
+    }
+  }
+
+  return { error: null }
+}