Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shared code in GCP implementation #22

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Use shared code in GCP implementation #22

merged 1 commit into from
Nov 10, 2023

Conversation

nweires
Copy link
Collaborator

@nweires nweires commented Nov 10, 2023

Use the shared code from #20 in GCP implementation.

Almost forgot about this step 😅

@nweires nweires requested a review from lathanh November 10, 2023 15:49
Copy link

File Coverage
All files 85%
base.py 90%
eagle.py 77%
exc.py 57%
local.py 70%
postprocessing.py 84%
utils.py 91%
cloud/docker_base.py 0%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 86%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against 4b103ae

@nweires nweires merged commit 495455f into gcp Nov 10, 2023
6 of 7 checks passed
@nweires nweires deleted the natalie/refactor branch November 10, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants