Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prep_batches in gcp.py #33

Closed
wants to merge 1 commit into from
Closed

Conversation

nweires
Copy link
Collaborator

@nweires nweires commented Nov 21, 2023

Updates the GCP implementation to share code with AWS for setting up batches of simulations to be run in parallel.

Testing: I did a test run to check that everything still works.

Copy link

File Coverage
All files 86%
base.py 90%
eagle.py 77%
exc.py 57%
local.py 70%
postprocessing.py 84%
utils.py 91%
cloud/docker_base.py 93%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 86%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against d95a38e

@nweires nweires requested a review from lathanh November 27, 2023 20:47
@nweires
Copy link
Collaborator Author

nweires commented Nov 27, 2023

@lathanh This may all be covered by your changes in #34, in which case I can just close this PR. But if it makes the changes there more concise/clear, I can merge this first. Either way is fine with me.

@nweires nweires closed this Nov 30, 2023
@nweires nweires deleted the natalie/prep_gcp_batches branch December 11, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant