Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickly fail if an existing job has the same ID #40

Merged
merged 6 commits into from
Dec 6, 2023
Merged

Conversation

nweires
Copy link
Collaborator

@nweires nweires commented Dec 4, 2023

Fail quickly if the user tries to start a job with the same ID as an existing job.

We still have the option to reattach to an existing job later, but for now we should at least fail early instead of after the Docker image has been built and pushed.

Copy link

github-actions bot commented Dec 4, 2023

File Coverage
All files 86%
base.py 90%
eagle.py 77%
exc.py 57%
local.py 70%
postprocessing.py 83%
utils.py 91%
cloud/docker_base.py 87%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 86%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against b08b32f

@nweires nweires requested a review from lathanh December 4, 2023 17:07
buildstockbatch/gcp/gcp.py Outdated Show resolved Hide resolved
buildstockbatch/gcp/gcp.py Outdated Show resolved Hide resolved
buildstockbatch/gcp/gcp.py Show resolved Hide resolved
buildstockbatch/gcp/gcp.py Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@nweires nweires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this quite a bit, so please take another look.

buildstockbatch/gcp/gcp.py Outdated Show resolved Hide resolved
buildstockbatch/gcp/gcp.py Show resolved Hide resolved
@nweires nweires requested a review from lathanh December 5, 2023 16:01
buildstockbatch/gcp/gcp.py Show resolved Hide resolved
buildstockbatch/gcp/gcp.py Outdated Show resolved Hide resolved
buildstockbatch/gcp/gcp.py Outdated Show resolved Hide resolved
buildstockbatch/gcp/gcp.py Outdated Show resolved Hide resolved
@lathanh
Copy link
Member

lathanh commented Dec 5, 2023

Quickly fail if...

FYI, "fail-fast" is a fairly well-defined term for this.

@nweires nweires merged commit f0bdd19 into gcp Dec 6, 2023
6 checks passed
@nweires nweires deleted the natalie/existing_job branch December 6, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants