-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the ability to skip baseline sims in Docker-based implementations #52
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against e4bf9b7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Robert! This looks good to me and I just added a small comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add a test case here for this?
Done |
Checklist
Not all may apply
Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)minimum_coverage
in.github/workflows/coverage.yml
as necessary.Update validation for project config yaml file changesUpdate existing documentationRun a small batch run on Kestrel/Eagle to make sure it all works if you made changes that will affect Kestrel/EagleAdd to the changelog_dev.rst file and propose migration text in the pull request