Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ability to skip baseline sims in Docker-based implementations #52

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

lathanh
Copy link
Member

@lathanh lathanh commented Jan 9, 2024

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/coverage.yml as necessary.
  • All other unit and integration tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run on Kestrel/Eagle to make sure it all works if you made changes that will affect Kestrel/Eagle
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@lathanh lathanh added the bug Something isn't working label Jan 9, 2024
@lathanh lathanh self-assigned this Jan 9, 2024
@lathanh lathanh marked this pull request as ready for review January 9, 2024 00:26
Copy link

github-actions bot commented Jan 9, 2024

File Coverage
All files 86%
base.py 91%
exc.py 57%
hpc.py 78%
local.py 70%
postprocessing.py 84%
utils.py 91%
cloud/docker_base.py 78%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/shared_testing_stuff.py 85%
test/test_docker.py 33%
test/test_local.py 97%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 86%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against e4bf9b7

Copy link

@mfathollahzadeh mfathollahzadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Robert! This looks good to me and I just added a small comment

buildstockbatch/cloud/docker_base.py Show resolved Hide resolved
Copy link
Collaborator

@nweires nweires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a test case here for this?

buildstockbatch/cloud/docker_base.py Show resolved Hide resolved
buildstockbatch/cloud/docker_base.py Outdated Show resolved Hide resolved
@lathanh
Copy link
Member Author

lathanh commented Jan 9, 2024

Can you also add a test case here for this?

Done

buildstockbatch/test/test_docker_base.py Outdated Show resolved Hide resolved
@lathanh lathanh merged commit 7ef4514 into gcp Jan 11, 2024
6 checks passed
@lathanh lathanh deleted the lathanh/skip_sims branch January 11, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants