-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up docker containers #55
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against 856b75c |
buildstockbatch/gcp/gcp.py
Outdated
@@ -577,7 +581,7 @@ def start_batch_job(self, batch_info): | |||
# Give three minutes per simulation, plus ten minutes for job overhead | |||
task_duration_secs = 60 * (10 + batch_info.n_sims_per_job * 3) | |||
task = batch_v1.TaskSpec( | |||
runnables=[runnable], | |||
runnables=[runnable, prune], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that there are two runnables, can we rename runnable
to something like bsb_runnable
?
And maybe a better name than prune
might be cleanup_runnable
(hide the implementation detail) or docker_prune_runnable
(qualify what's being pruned). I lean towards the former, fwiw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed - this was a quick version to start testing with, but I'll clean it up before merging.
Clean up our docker containers at the end of each task.
This should be handled by GCP Batch, but since it's not, do it ourselves.
Tested: