Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase retry limit #60

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Increase retry limit #60

merged 1 commit into from
Jan 22, 2024

Conversation

nweires
Copy link
Collaborator

@nweires nweires commented Jan 19, 2024

Increase from 3 tries (for preemptions) to 5.

Copy link

File Coverage
All files 86%
base.py 91%
exc.py 57%
hpc.py 78%
local.py 70%
postprocessing.py 84%
utils.py 91%
cloud/docker_base.py 78%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/shared_testing_stuff.py 85%
test/test_docker.py 33%
test/test_local.py 97%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 86%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against 89521cd

@@ -619,7 +619,7 @@ def start_batch_job(self, batch_info):
runnables=[bsb_runnable],
compute_resource=resources,
# Allow retries, but only when the machine is preempted.
max_retry_count=3,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was wondering if we should capture anything about which tasks really succeed with a retry of 3 or higher?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can get this info from the batch API at the end, if needed.

@nweires nweires merged commit b7fad48 into gcp Jan 22, 2024
6 of 7 checks passed
@nweires nweires deleted the natalie/retry branch January 22, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants