Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for existing output files during validation #65

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

nweires
Copy link
Collaborator

@nweires nweires commented Feb 5, 2024

This is to avoid the problem of output files from a previous job being mixed with those from a later job that writes to the same location.

Currently, files can end up mixed together if either 1) the second job had few tasks (so didn't overwrite all the existing files) or 2) the second job had some tasks fail.

Copy link

github-actions bot commented Feb 5, 2024

File Coverage
All files 86%
base.py 91%
exc.py 57%
hpc.py 78%
local.py 70%
postprocessing.py 84%
utils.py 91%
cloud/docker_base.py 79%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/shared_testing_stuff.py 85%
test/test_docker.py 33%
test/test_local.py 97%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 86%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against 400e94f

Copy link

@mfathollahzadeh mfathollahzadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me!

@nweires nweires merged commit bcc584c into gcp Feb 6, 2024
6 of 7 checks passed
@nweires nweires deleted the natalie/check_output branch February 6, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants