Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netboot cleanup for additional files #686

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Aug 19, 2024

  1. Suppress file open failures for some netboot cases

    Reading files during a netboot comes with the caveat that
    fetching files from a network does not support anything
    like listing a directory. In the past this has meant that
    we do not try to open optional files during a netboot.
    However at least the revocation.efi file is now tested
    during a netboot, which will print an error when it is not
    found. Since that error is spurious we should allow for
    those errors to be suppressed.
    
    This is also desirable since we will likely go looking for
    additional files in the near future.
    jsetje committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a597437 View commit details
    Browse the repository at this point in the history
  2. Allow indepdent SkuSi and SBAT revocation updates

    While a revocations.efi binary can contain either SBAT revocations,
    SkuSi revocations, or both, it is desirable to package them separately
    so that higher level tools such as fwupd can decide which ones to put
    in place at a given moment. This changes revocations.efi to
    revocations_sbat.efi and revocations_sku.efi
    
    XXX: Retain support a common revocations.efi file?
         Constrain the sections to match the file?
    jsetje committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    224e914 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. netboot: process revocations.efi as revocations not shim_certificate

    Bugfix: In the netboot case revocations.efi files were read, but
    processed as shim_certificate.efi files which is simply wrong.
    jsetje committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    3412508 View commit details
    Browse the repository at this point in the history
  2. netboot can try to load shim_certificate_[0..9].efi

    Since we can't read the directory, we can try to load
    shim_certificate_[0..9].efi explicitly and give up after
    the first one that fails to load.
    
    XXX: should we just bring in snprintf()?
         support more than 10?
         nameing scheme
    jsetje committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    e9aef68 View commit details
    Browse the repository at this point in the history