Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Updated the version from 4.0 to 4.1 #99

Open
wants to merge 1 commit into
base: new-branding
Choose a base branch
from

Conversation

nizamial09-zz
Copy link

This commits fixes the Rebranding issue and updates the version in 'About' page of RHCS Ceph Dashboard from 4.0 to 4.1

Signed-off-by: Nizamudeen [email protected]

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs

This commits fixes the Rebranding issue and updates the version in 'About' page of RHCS Ceph Dashboard from 4.0 to 4.1

Signed-off-by: Nizamudeen <[email protected]>
Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We'll need to check with docs team whether the DocsUrls.base remains the same for 4.1 (no placeholder for minor version in the URL).

BTW, this PR is not meant to be merged, just for reviewing purposes.

@nizamial09-zz
Copy link
Author

Looks good! We'll need to check with docs team whether the DocsUrls.base remains the same for 4.1 (no placeholder for minor version in the URL).

Yeah, that needs to be checked.

@epuertat epuertat added the branding Everything related to branding and styling. label Mar 18, 2020
@epuertat epuertat added this to the 4.1 milestone Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branding Everything related to branding and styling.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants