Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix name size from edit Label (in backend and frontend). #849

Closed
wants to merge 4 commits into from
Closed

Fix name size from edit Label (in backend and frontend). #849

wants to merge 4 commits into from

Conversation

CherifAmine
Copy link
Contributor

Description

Fix name size from edit Label

Changes Made

Closes Issue(s)

Related Issue(s)

#617

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Automated testing implementation or update
  • Dependencies updated to a newer version
  • Documentation update
  • Experimental feature that requires further discussion

Screenshots and screen captures

image

@marwa-benhassine marwa-benhassine added quality control: approved Changes Requested (for feedback from the QA testing team) quality control: changes requested Approved (for when the QA testing team approves the changes) and removed quality control: approved Changes Requested (for feedback from the QA testing team) labels Jul 28, 2023
@GhaziTriki
Copy link
Member

Indeed error display in BBBeasy forms are global and rarely contextual by choice. @marwa-benhassine Can you tell us why QA is requesting changes?

@marwa-benhassine
Copy link
Contributor

marwa-benhassine commented Jul 31, 2023 •
edited
Loading

@CherifAmine

image

The validation error message should be global and displayed above the form like the validation message in installer

like this one :

image

@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
15.2% 15.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@CherifAmine CherifAmine added the component: labels Changes related to labeling or categorization of issues or pull requests. label Aug 1, 2023
@marwa-benhassine
Copy link
Contributor

when we keep the label name without changes the validation error message should not remain static but rather disappear .

label name cannot

@CherifAmine
Copy link
Contributor Author

Fix in PR : #855

@CherifAmine CherifAmine closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marwa-benhassine marwa-benhassine

Labels
component: labels Changes related to labeling or categorization of issues or pull requests. quality control: changes requested Approved (for when the QA testing team approves the changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CherifAmine @GhaziTriki @marwa-benhassine