Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Metric Package #69

Open
wants to merge 14 commits into
base: feat/metrics-middlewares
Choose a base branch
from
Open

Feat: Metric Package #69

wants to merge 14 commits into from

Conversation

ilhamsyahids
Copy link
Collaborator

@ilhamsyahids ilhamsyahids commented Oct 13, 2024 •
edited
Loading

Summary:

Added new package for metrics, for context see: #24 (comment)

To make it easier, we provide these metrics as example for future metrics middleware:

  • request_duration_milliseconds
  • requests_inflight
  • response_size_bytes

@ilhamsyahids
revert metrics
74bd3a5 
This reverts commit 7f4f21a.

Signed-off-by: Ilham Syahid S <[email protected]>
@ilhamsyahids
feat: add metric configuration and version information
3db713e 
Signed-off-by: Ilham Syahid S <[email protected]>
@ilhamsyahids
feat: add response size metrics
0343070 
Signed-off-by: Ilham Syahid S <[email protected]>
@ilhamsyahids ilhamsyahids self-assigned this Oct 13, 2024
@ilhamsyahids
feat: add request duration in milliseconds metrics
93d6297 
Signed-off-by: Ilham Syahid S <[email protected]>
@ilhamsyahids
feat: add requests inflight metrics
0963b0d 
Signed-off-by: Ilham Syahid S <[email protected]>
@ilhamsyahids
feat: add base metrics middleware
5b2a389 
Signed-off-by: Ilham Syahid S <[email protected]>
@ilhamsyahids
refactor: metrics to follow base middleware
02b6427 
Signed-off-by: Ilham Syahid S <[email protected]>
@ilhamsyahids
feat: add metrics into basic example
750b56b 
Signed-off-by: Ilham Syahid S <[email protected]>
@ilhamsyahids
sync master
9766e56 
Signed-off-by: Ilham Syahid S <[email protected]>
@ilhamsyahids
test: add metrics middleware test
0a69031 
Signed-off-by: Ilham Syahid S <[email protected]>
@ilhamsyahids
test: add metrics request duration test
0067fe4 
Signed-off-by: Ilham Syahid S <[email protected]>
@ilhamsyahids
test: add metrics request inflight test
830f58d 
Signed-off-by: Ilham Syahid S <[email protected]>
@ilhamsyahids
test: add metrics response size test
ada254f 
Signed-off-by: Ilham Syahid S <[email protected]>
@ilhamsyahids ilhamsyahids changed the base branch from feat/metrics-middlewares to sync/metrics-master November 16, 2024 09:37
@ilhamsyahids
sync
93c394b 
Signed-off-by: Ilham Syahid S <[email protected]>
Base automatically changed from sync/metrics-master to feat/metrics-middlewares November 16, 2024 09:42
@ilhamsyahids ilhamsyahids marked this pull request as ready for review November 16, 2024 09:49
@ilhamsyahids ilhamsyahids mentioned this pull request Nov 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riandyrn riandyrn Awaiting requested review from riandyrn riandyrn is a code owner

Assignees

@ilhamsyahids ilhamsyahids

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ilhamsyahids