Skip to content

Commit

Permalink
v0.5.1 - cleanup + CreateMissingResources EndpoingDefault
Browse files Browse the repository at this point in the history
  • Loading branch information
rickdotnet committed Nov 2, 2024
1 parent 9cf321a commit 0f952e5
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 8 deletions.
2 changes: 1 addition & 1 deletion build/version.props
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>
<VersionMajor>0</VersionMajor>
<VersionMinor>5</VersionMinor>
<VersionPatch>0</VersionPatch>
<VersionPatch>1</VersionPatch>
<VersionQuality />
<VersionPrefix>$(VersionMajor).$(VersionMinor).$(VersionPatch)$(VersionQuality)</VersionPrefix>
</PropertyGroup>
Expand Down
4 changes: 2 additions & 2 deletions src/Apollo.Extensions.Microsoft.Hosting/ApolloBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public interface IApolloBuilder
IApolloBuilder WithEndpointProvider<TProvider>() where TProvider : class, IEndpointProvider;
}

public class ApolloBuilder : IApolloBuilder
internal class ApolloBuilder : IApolloBuilder
{
public IServiceCollection Services { get; }
private ApolloConfig config = new();
Expand Down Expand Up @@ -124,7 +124,7 @@ public IApolloBuilder WithEndpointProvider<TProvider>() where TProvider : class,
return this;
}

public void Build()
internal void Build()
{
Services.AddSingleton(config);
Services.AddSingleton<ApolloClient>();
Expand Down
2 changes: 0 additions & 2 deletions src/Apollo.Extensions.Microsoft.Hosting/Startup.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
using Apollo.Configuration;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.DependencyInjection.Extensions;

namespace Apollo.Extensions.Microsoft.Hosting;

Expand Down
1 change: 0 additions & 1 deletion src/Apollo.Providers.NATS/NatsJetStreamSubscription.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
using Apollo.Abstractions;
using Apollo.Configuration;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Primitives;
using NATS.Client.Core;
using NATS.Client.JetStream;
using NATS.Client.JetStream.Models;
Expand Down
1 change: 1 addition & 0 deletions src/Apollo/ApolloClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ private EndpointConfig SetEndpointDefaults(EndpointConfig config, Type? endpoint
ConsumerName = config.ConsumerName
?? apolloConfig.DefaultConsumerName
?? throw new Exception("ConsumerName is required."),
CreateMissingResources = config.CreateMissingResources || apolloConfig.CreateMissingResources,
Namespace = config.Namespace ?? apolloConfig.DefaultNamespace,
EndpointType = config.EndpointType ?? endpointType,
SubscriptionProvider = config.SubscriptionProvider ?? defaultSubscriptionProvider,
Expand Down
2 changes: 0 additions & 2 deletions tests/Apollo.Tests/ApolloClientTests.cs
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
using System.Text;
using Apollo.Abstractions;
using Apollo.Configuration;
using Apollo.Providers.Memory;
using FakeItEasy;
using Newtonsoft.Json;
using JsonSerializer = System.Text.Json.JsonSerializer;

namespace Apollo.Tests;
Expand Down

0 comments on commit 0f952e5

Please sign in to comment.