Allow custom Http client options #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the awesome package!
I was using this locally and was getting curl errors:
cURL error 60: SSL certificate problem: unable to get local issuer certificateAfter realising that I couldn't modify the
verifyoption with a globalRequestMiddleware I decided to add awithOptionsmethod to enable it.I've updated the README accordingly.
Testing
I spent several hours (I know!) trying to find a way to test this, but with how I'm setting the options there does not seem to be a way that I could find. I source-dived, and xDebugged, but the option seems to be set on the curl instance and with the
FakeI don't think we even get to that depth in the test.I tried to create a mock, but this felt like we were just testing that the new method does what the new method does.
Happy to take your advice here.
Thanks.